ReflectionDocBlock icon indicating copy to clipboard operation
ReflectionDocBlock copied to clipboard

chore(deps): allow webmozart/assert v2

Open simPod opened this issue 1 month ago • 2 comments

simPod avatar Dec 17 '25 10:12 simPod

@simPod There are no changes to composer.json in commit.

andrew-demb avatar Dec 17 '25 13:12 andrew-demb

I was tinkering with CI and accidentally removed the change. Fixed, thx.

simPod avatar Dec 17 '25 13:12 simPod

Could you please change the types like suggested by Psalm? https://github.com/phpDocumentor/ReflectionDocBlock/blob/5.x/src/Utils.php#L58

Chris53897 avatar Dec 19 '25 16:12 Chris53897

I've cleaned up the composer.lock change. It should not be committed in the library repo so I'll try not to touch it.

simPod avatar Dec 22 '25 19:12 simPod

i am not sure if psalm run is correct now. My intention was this change. https://github.com/phpDocumentor/ReflectionDocBlock/pull/427/files#diff-29604b8d3d680574d348a450de44692476847958c077b350b4dd553c4864f07dR46

Chris53897 avatar Dec 22 '25 19:12 Chris53897

I know but the point is that it is not relevant to this change. The psalm issue is on master as well right now.

Currently psalm check passes on this commit, same as it does on master https://github.com/simPod/ReflectionDocBlock/actions/runs/20441409379/job/58735043783

simPod avatar Dec 22 '25 20:12 simPod

It could be the psalm error is triggered by a change in webmozart/assert. I see @Chris53897 created a new PR. CI is running on both now.

jaapio avatar Dec 22 '25 21:12 jaapio

I don't know why CI did not pass at the first run, it's now ok. So merged this.

Thanks for your help!

jaapio avatar Dec 22 '25 21:12 jaapio

Thanks @simPod @jaapio

Chris53897 avatar Dec 22 '25 21:12 Chris53897