pecl-mail-mailparse icon indicating copy to clipboard operation
pecl-mail-mailparse copied to clipboard

Update ci.yml to build the windows extensions

Open reeperbahnause opened this issue 1 year ago • 1 comments

This commit modifies the ci.yml to build the windows extension for php version 8.2 and 8.3 Php version prior to 8.2 are not included because the extensions are available at the pecl. Building the extension for php version 8.4 is not possible yet. Thanks to @cmb69 who helped with a hint of how to load the mbstring extension using the --enable-test-ini argument. #36

reeperbahnause avatar Aug 27 '24 05:08 reeperbahnause

Php version prior to 8.2 are not included because the extensions are available at the pecl.

There are also 8.2 and 8.3 builds on PECL. But the main point of having CI here is verification that the extension can be built, and that the tests are running. I suggest to enable 8.0 and 8.1 builds.

Building the extension for php version 8.4 is not possible yet.

It should be (unless there is an issue with mailparse itself, in which case it would be good to see what that is). You need to update setup-php-sdk to v9, and also to switch to windows-2022. That should do. (Building for 7.4 is also possible, but somewhat tricky, and having builds for 5 PHP versions is already quite something.)

Thanks to @cmb69 who helped with a hint of how to load the mbstring extension using the --enable-test-ini argument.

Yeah, that is a terrible hack, but for now it should do. The setup-php-sdk action should at least provide the build path (that's useful for other task too), and maybe more.

Anyhow, thanks for your work!

cmb69 avatar Aug 27 '24 21:08 cmb69