pecl-database-mysql icon indicating copy to clipboard operation
pecl-database-mysql copied to clipboard

Update php_mysql.c

Open futureweb opened this issue 8 years ago • 2 comments

As mysql_list_fields() was removed from mysqlnd we should throw Error here I guess ... https://github.com/php/php-src/commit/398caf9336a5f6a71439969c7fd610bfaf522b93#diff-48eed863ec9451a1280e0e2d1d8e45b0

futureweb avatar Feb 06 '18 09:02 futureweb

I believe the better way is to export the function only when it can be used. Then a user can check via function_exists(). By throwing an error the user has no way to handle this gracefully.

On Di, 2018-02-06 at 09:47 +0000, Andreas Schnederle-Wagner wrote:

As mysql_list_fields() was removed from mysqlnd we should throw Error here I guess ... php/php-src@398caf9#diff-48eed863ec9451a1280e0e2d1d8e45b0 You can view, comment on, or merge this pull request online at:   https://github.com/php/pecl-database-mysql/pull/1 Commit Summary Update php_mysql.c File Changes M php_mysql.c (4) Patch Links: https://github.com/php/pecl-database-mysql/pull/1.patch https://github.com/php/pecl-database-mysql/pull/1.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

johannes avatar Feb 06 '18 12:02 johannes

guess you are right - would be the more sophisticated approach to this ;-)

futureweb avatar Feb 06 '18 14:02 futureweb