feat: rename `DEBUG` env var to `CADDY_DEBUG`

Open chalasr opened this issue 3 years ago • 2 comments

Fixes #57

Oct 31 '22 22:10 chalasr

Are we sure we won't want to reuse this flag at some point for other purposes (non caddy related)? Otherwise FRANKENPHP_DEBUG might be more future proof. Just wondering

Could you open the same PR on Symfony Docker and API Platform, please?

Sure!

Oct 31 '22 23:10 chalasr

As this env var contains a string that will be injected in Caddyfile, I think it's good as-is.

Nov 01 '22 07:11 dunglas

Alright then. Companion PRs: https://github.com/api-platform/api-platform/pull/2313, https://github.com/dunglas/symfony-docker/pull/31

Nov 01 '22 14:11 chalasr

Thanks @chalasr!

Nov 03 '22 07:11 dunglas