frankenphp icon indicating copy to clipboard operation
frankenphp copied to clipboard

Idea: mandatory PR performance tests

Open henderkes opened this issue 1 month ago • 3 comments

Describe your feature request

We're approaching a point where we have quite a few things in our code to improve performance. For behavioural regressions we already have a great amount of tests, but for the case of performance regressions, we should build something too.

Unfortunately, this isn't quite as simple as we have to cover a multitude of scenarios and rely on hardware with predictable performance (i.e. soft hosted runners). Is this something we're interested in pursuing either way? @php/frankenphp-collaborators

henderkes avatar Nov 23 '25 15:11 henderkes

We could at least use the built-in Go benchmarking feature to do some basic tests.

dunglas avatar Nov 23 '25 16:11 dunglas

I was just thinking about this today.

For the runners, I'd be happy to donate some self-hosted runners. I have two identical (physical) machines in a k8s cluster -- so downtime should be mostly minimal. There are other machines in the cluster as well, but I'd prefer to pin it to the two identical ones. It takes ~15 minutes to set up, but I don't have the necessary repository permissions to set it up.

withinboredom avatar Nov 23 '25 19:11 withinboredom

If you have hardware for it, that's great. Kevin could probably set it up with you.

henderkes avatar Nov 23 '25 19:11 henderkes