frankenphp icon indicating copy to clipboard operation
frankenphp copied to clipboard

debug ci failures

Open alexandre-daubois opened this issue 6 months ago • 3 comments

jq is a more robust and maintainable approach to parse JSON when building images instead of using grep | awk | sed. This may help with the CI failures of https://github.com/php/frankenphp/pull/1651, where curl complains of missing URL in some steps. Related or not, I think this is a nice change for a more comprehensive build.

alexandre-daubois avatar Jun 23 '25 08:06 alexandre-daubois

jq is not used intentionally because it is not available in the base Docker image, and we want to keep it as small as possible.

dunglas avatar Jun 23 '25 09:06 dunglas

Alright, let's close this then

alexandre-daubois avatar Jun 23 '25 09:06 alexandre-daubois

Actually reopening it for to test CI failures, I'll close it soon

alexandre-daubois avatar Jun 23 '25 09:06 alexandre-daubois

Closed in favor of https://github.com/php/frankenphp/pull/1680

alexandre-daubois avatar Jun 23 '25 14:06 alexandre-daubois