frankenphp icon indicating copy to clipboard operation
frankenphp copied to clipboard

[feat] Code change for compile on windows. Needs to modify php-src.

Open TenHian opened this issue 1 year ago • 5 comments

TenHian avatar Dec 22 '24 14:12 TenHian

Thanks for your comments. I've take them and added the compilation documentation.

TenHian avatar Dec 24 '24 11:12 TenHian

@dunglas Is it still worthwhile to carry on with this route?

TenHian avatar Jan 07 '25 09:01 TenHian

@cmb69 do you have any insight in the changes to the build script that maybe should be upstreamed?

Girgias avatar Feb 25 '25 10:02 Girgias

See https://github.com/php/php-src/issues/17476 about the php-src issues. https://github.com/php/php-src/pull/17480 allows to build php8embed.dll (the implementation is a bit hackish, so php8embed.lib stays default for BC reasons), what would be a step. But there are still issues when trying to build FrankenPHP, because cgo doesn't support MSVC (or clang-cl), but PHP does not properly support MinGW, but even when fixing the latter, the result might not necessarily be ready for production. At least there would likely be issues with our ZEND_FASTCALL. In my opinion, cgo would need to support MSVC, but there appears to be no progress.

cmb69 avatar Feb 25 '25 11:02 cmb69

Any update to go on this PR?

MisterDuval avatar Sep 18 '25 09:09 MisterDuval