frankenphp icon indicating copy to clipboard operation
frankenphp copied to clipboard

Add explicit information that the `frankenphp_handle_request` function was not called

Open 7-zete-7 opened this issue 1 year ago • 2 comments

Currently, if the frankenphp_handle_request function is not called, FrankenPHP is restarted cyclically (see https://github.com/dunglas/symfony-docker/issues/708).

It would be nice if FrankenPHP could notify the developer more explicitly that the function was not called.

7-zete-7 avatar Dec 09 '24 15:12 7-zete-7

I think this could be coupled with being able to configure the max amount of calls to frankenphp_handle_request in the Caddy config.

And if there have been no calls, we can log an error or panic, not sure which one's better.

AlliBalliBaba avatar Dec 09 '24 16:12 AlliBalliBaba

To keep things simple, I would prefer to just log an error if the script exits without having call the function.

Configuring the maximum number of requests to handle is already possible (and done) user land. Let’ try to keep the core as small and focused as possible.

dunglas avatar Dec 09 '24 17:12 dunglas

Closed by https://github.com/php/frankenphp/pull/1437

7-zete-7 avatar Jun 20 '25 15:06 7-zete-7