doc-en
doc-en copied to clipboard
php
Copy constants from curl_getinfo() to constants page
Copy constants from curl_getinfo() to constants page, merge descriptions of constants on both pages, remove existing constants from constants page and add all constants to their own constant list which will be rendered as a table.
Used the following script to make the first commit: https://gist.github.com/haszi/fed1dca8fb3d88cd09d5b5ef64f4506a
After running the script, the whitespace and the missing period between some of the descriptions' sentences has been fixed manually. If this script is used to update translations, the same punctuation check should be done.
I have created a new file just for the curl_getinfo() constants and included it in the main cURL constants file.
Edit: I also updated the script to do the same so it is easier to apply this change to the translations and to make it easier to review the changes.
As we are creating a new file I don't think I need the script, but can you try and reorder the commits to be first the move of the relevant constants into the new file, and then have the since -> as of conversion commit happen?
I just pushed the requested changes and also added some missing <constant> and <replaceable> tags in a separate commit.
Can you merge the last commit with the first one in a rebase, and force push so that I can merge the PR with a rebase?
Can you merge the last commit with the first one in a rebase, and force push so that I can merge the PR with a rebase?
Done.
I've also updated the script I've made the first commit with (just in case anyone wants to use it to do the same in the translations).