symfony-bundle
symfony-bundle copied to clipboard
php-translation
Allow Symfony 7
Thank you for this PR! Test failures look related, could you rebuild with the latest changes in master branch, I started using Composer v2 in #503 - hopefully it will fix most fails
The problem is that this bundle depends on other bundles that do not have Symfony 7 support yet, e.g:
- https://github.com/php-translation/extractor/pull/172
- https://github.com/php-translation/symfony-storage/pull/64
- https://github.com/php-translation/common/pull/52
So to make this bundle trully support Symfony 7 - we need to add Symfony 7 support to the bundles mentioned above first, make releases for them, and finally merge this PR if tests pass.
I tried to quickly allow Symfony 7 support in those bundles, but as you can see tests failed there. Unfortunately, I don't have time yet to fix them, if anyone wants to be a volunteer to help fixing tests in those packages - please, let me know... or just create a new PR with proper fixes. As soon as we're green - I will be happy to review / merge and move it forward.
Hello. What is the current status? I saw that there are recent changes in the named packages, do you need more help?
@byhaskell https://github.com/php-translation/extractor/pull/172#issuecomment-1916844118 currently the part where this is stuck.
What about a dropping the extractor and using Symfony's translation:extract command?
I've haven't checked what the extractor is doing, but it sounds that those two are doing similar things.
If I am not mistaken, this PR can be updated now that the other components support 7+
I updated this PR with the latest changes in master, but seems we need more work here because some tests fail
@andreybolonin could you take a look?
@bocharsky-bw any ideas why? https://symfony.com/doc/current/reference/twig_reference.html#file-link
Hm, IIRC that file_link() Twig filter comes from symfony/debug-bundle, make sure that bundle is installed and enabled for the current Sf env - probably start looking into this direction.
Hm, IIRC that
file_link()Twig filter comes fromsymfony/debug-bundle, make sure that bundle is installed and enabled for the current Sf env - probably start looking into this direction.
Confirmed: Symfony/Bundle/WebProfilerBundle/Profiler/CodeExtension.php#L50
The class documentation explicitly mentions that the provided functions and filters should only be used in development environments though and never in production. Is the offending template in question something one would only use in a development environment?
Are you talking about WebUI/show.html.twig? That should be used in dev/test only I think
Is closing this topic some message that there wont be any updates to symfony 7 ? Or maybe is it already done? ;)
@pawellen Unfortunately, I don't know the reasons behind closing this PR. Sf 7 support is still a relevant issue for this repo, see #501. Seems no active Symfony 7 PRs currently, so if there are some volunteers who would like to help with it - please, PRs are warmly welcome here!