symfony-bundle icon indicating copy to clipboard operation
symfony-bundle copied to clipboard

Bundle does not work properly with new Intl ICU translations

Open snpy opened this issue 4 years ago • 6 comments

(Please ignore my ignorance if I should have followed PR guideline; PR was created in haste; if I should modify or redefine the PR please let me know and I'll fix it)

This PR is a proposition to handle ICU formats similarly as they are in Symfony internals.

The sanest way to deal with it is to stop using MessageCatalogue interface and look inside it with NSA package and determine manually if we should utilise ICU domain format or "normal" domain format.

Additional this PR introduces new_message_format configuration that will allow us to control if we'd like to use ICU format for new messages or not. I guess for compatibility reason I should have set it by default to "" instead of "icu", but that can be easily fixed if this PR will be accepted only because of this BC issue.

The code itself was based on 0.12.3 tag instead of master in case master changes require additional work.

This should be fixing first issue described at https://github.com/php-translation/symfony-bundle/issues/300 making bundle operational for translations kept in ICU formats.

snpy avatar Aug 24 '21 12:08 snpy

Hey @snpy ,

Thank you for working on this and sorry for the delays! Could you pull the latest changes from master to see tests are green here? Also, any pending work left here, or do you think this one is ready?

bocharsky-bw avatar Jan 20 '22 08:01 bocharsky-bw

@snpy could you at least check "Allow edits by maintainers" here, I'll try to rebase it myself to see if tests are green here

bocharsky-bw avatar Jan 25 '22 08:01 bocharsky-bw

@bocharsky-bw Hi, I will try to find some time to do it today or tomorrow.

I don't want to rebase current branch as it was intentionally based on specific tag version.

Will create new branch and rebase it (will also look into option you've mentioned). Current branch is being used on production, so I'd like to avoid 3rd party edits.

snpy avatar Jan 25 '22 12:01 snpy

Hey Marek! Sure, do it when you can, it's not an urgent question. And thank you for the work you did so far on this!

bocharsky-bw avatar Jan 25 '22 12:01 bocharsky-bw

any word on this? Would love to use this bundle with ICU support

LauLaman avatar Aug 19 '22 20:08 LauLaman

Sorry, but I had chronically little time lately. Will try to sync up changes with master before the end of August.

snpy avatar Aug 20 '22 15:08 snpy

is it still alive?

wokenlex avatar Nov 24 '22 12:11 wokenlex

Sorry; slipped my mind. I'm going to try to have conflicts resolved and move things forward.

snpy avatar Nov 24 '22 12:11 snpy

@bocharsky-bw Changes here should be ready for the review/testing. Thanks in advance.

snpy avatar Nov 24 '22 22:11 snpy

@bocharsky-bw One PHP-CS-Fixer suggestions as applied and one was fetched from the master. Now all checks should be green all the way. Thanks.

snpy avatar Jan 11 '23 15:01 snpy

Thank you for finishing it, Marek!

bocharsky-bw avatar Jan 23 '23 09:01 bocharsky-bw

Thanks for merging it. Sorry it took soooo long.

snpy avatar Jan 23 '23 10:01 snpy