extractor icon indicating copy to clipboard operation
extractor copied to clipboard

FormTypePlaceholder visitor new features.

Open idybil opened this issue 7 years ago • 1 comments

Hi,

I think that the FormTypePlaceholder visitor should be able to:

  • Extract from an array which is allowed (ex.: when using a DateTimeType) as you can see in the Symfony documentation : https://symfony.com/doc/current/reference/forms/types/datetime.html#placeholder

  • Should skip extraction if the placeholder value is a Boolean, (for now, I rely on the Ignore annotation). As you can see in the Symfony doc, we can put a Boolean for the placeholder https://symfony.com/doc/current/reference/forms/types/choice.html#placeholder

idybil avatar Jan 20 '18 20:01 idybil

Thank you. I've added https://github.com/php-translation/extractor/pull/90

Nyholm avatar Mar 23 '18 20:03 Nyholm