feat(road-runner): allow ^2023.1.0 and ^2.0

[alexander-schranz]

See #138 /cc @gsdevme

[alexander-schranz]

Looks currently there is a dependency to symfony/console missing not sure if we should add it to require or require-dev as the dependency is not defined by symfony/runtime class where it is used. @Nyholm what do you think?

[gsdevme]

Yeah its needed in require-dev, I cant push the change though on this branch @alexander-schranz

Problem is the maintainer of roadrunner-server/roadrunner isn't using semver anymore instead using year/month so Im not sure how its best to support.

[alexander-schranz]

@gsdevme you can just open another PR with the required require-dev to the symfony/console.

[alexander-schranz]

The spiral/roadrunner package seems not longer provide any PHP code since there version changes. The change is https://github.com/roadrunner-server/roadrunner/commit/8d316e575e8e72f38e9f2e8f587f5bf7a006ef95 So I think spiral/roadrunner is not longer the way to go.

Maybe @roxblnfk can help us out what packages we should require here. From first look at I would see we require roadrunner-php/worker ^2 || ^3. But not sure if the cli and worker is also required?

The classes we access are:

https://github.com/php-runtime/runtime/blob/1c6ac3dad61b35e126541190232b497ed934c170/src/roadrunner-symfony-nyholm/src/Runner.php#L35-L36

https://github.com/php-runtime/runtime/blob/1c6ac3dad61b35e126541190232b497ed934c170/src/roadrunner-nyholm/src/Runner.php#L23-L25

[rustatian]

Hey @alexander-schranz 👋🏻 😃 Yeah, RR is metapackage since v2023.1.0. Currently, spiral\roadrunner-worker, spiral\roadrunner-http and spiral\roadrunner-cli are required. They should be installed manually.

IIRC (my poor PHP knowledge 😢), cli is only required to install RR. If you use only http plugin:

composer require spiral/roadrunner-http nyholm/psr7

[roxblnfk]

Hi @alexander-schranz ✋ Add spiral/roadrunner only if you are directly tied to any features of the RoadRunner server.

In the code of this package, classes from the following are used directly:

• spiral/roadrunner-http
• spiral/roadrunner-worker

The spiral/roadrunner-cli is helpful to load RoadRunner server binary files using vendor/bin/rr get.

I recommend using the latest versions of the mentioned packages. However, you can try a wider range of versions, excluding spiral/roadrunner:

spiral/roadrunner-http: ^2 || ^3.2
spiral/roadrunner-worker: ^2 || ^3
spiral/roadrunner-cli: ^2

[alexander-schranz]

Thx @roxblnfk, think in our case it does make sense to go with:

spiral/roadrunner-http: ^2 || ^3.2
spiral/roadrunner-worker: ^2 || ^3
spiral/roadrunner-cli: ^2

which was also the previous packages which where installed when using "spiral/roadrunner": "^2.0".

@Nyholm are you fine with that?

[Nyholm]

Yepp. I think that makes sense. Thank you

[davidPaymefy]

Hi, do we know when this is going to be available? spiral/roadrunner is already on version 2024

[davidPaymefy]

Hi, do we know when this is going to be available? spiral/roadrunner is already on version 2024

https://github.com/php-runtime/runtime/pull/172

[alexander-schranz]

close in favor of #172