socket-client icon indicating copy to clipboard operation
socket-client copied to clipboard

Published 20 hours ago • verified publisher icon php-http

fix: Typehint the Stream class and fix deprecated interface HttpClient

Open tarekdj opened this issue 1 year ago • 2 comments

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

  • Fix the type hinting of Stream class in order to make it compatible with StreamInterface
  • Replace depreacted interface HttpClient

Why?

Fix the compatibility of Stream class with the StreamInterface

Checklist

  • [x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • [x] Documentation pull request created (if not simply a bugfix)

To Do

  • [x] Update CHANGELOG.md

tarekdj avatar Oct 23 '23 21:10 tarekdj

we could switch this client to be a PSR-18 client. but that would mean somebody would need to commit to maintain this client. there are a bunch of http clients around: symfony, guzzle, buzz, the php-http/curl-client and some others.

is there value in keeping the socket client alive?

dbu avatar Jan 06 '24 12:01 dbu

if we decide to keep this maintained, we should adjust the socket-client.rst page in the documentation, reverting https://github.com/php-http/documentation/pull/310#discussion_r1193398598 and maybe add more information.

dbu avatar Jan 06 '24 15:01 dbu