message icon indicating copy to clipboard operation
message copied to clipboard

feat: remove ergebnis/composer-normalize

Open Chris53897 opened this issue 1 year ago • 2 comments

I want to test CI if is needed "ergebnis/composer-normalize" while it runs via docker gh actions

Chris53897 avatar Oct 14 '24 12:10 Chris53897

it seems to work. but we have some dev dependencies in composer.json require-dev so that people can run them locally, same with phpspec.

is there an issue with having normalize in the require-dev section?

dbu avatar Oct 14 '24 15:10 dbu

Only deprecations in the testruns for PHP 8.4. Example: https://github.com/php-http/message/actions/runs/11143029675/job/30967217820

I have created a PR. https://github.com/localheinz/diff/pull/72

But i thought maybe it is not needed anymore, as it runs via docker gh actions.

Chris53897 avatar Oct 15 '24 08:10 Chris53897

@Chris53897 the fix to localheinz/diff has been merged and tagged. did that solve the deprecations, can we close this MR?

dbu avatar Feb 15 '25 10:02 dbu

Thanks for the reminder. It looks good. https://github.com/php-http/message/actions/runs/13344353123/job/37272964327?pr=167 I will clsoe this PR.

Chris53897 avatar Feb 15 '25 10:02 Chris53897