message-factory icon indicating copy to clipboard operation
message-factory copied to clipboard

Test on PHP 8

Open GrahamCampbell opened this issue 5 years ago • 2 comments

There is no upper bound on the PHP version (and too late to add one in 1.x). We should test on PHP 8.0 with the CI.

GrahamCampbell avatar Jul 06 '20 09:07 GrahamCampbell

i wonder if we don't want to add the upper bound anyways. then at least in the future, we are more robust.

dbu avatar Jul 06 '20 11:07 dbu

An upperbound would be a good idea, because almost certainly PHP 9 will have totally deleted the concept of a resource, so things like https://github.com/php-http/message-factory/blob/master/src/StreamFactory.php#L17 need updating with whatever the replacement for fopen's return type is, and related types.

GrahamCampbell avatar Jul 06 '20 13:07 GrahamCampbell