documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Migration: recommend a two step migration

Open sagikazarmark opened this issue 9 years ago • 5 comments

I think most people fear from breaking BC. I absolutely agree with them, that's why I think we should recommend them a two step migration.

  1. Use HTTPlug internally, don't change the public API. In most cases this is a simple constructor injection of an HTTP Client. We could just wrap this around one of our adapter and use HTTPlug API internally.
  2. Once the author is confident that the package is stable and HTTPlug works, he can change the public API as well, fully decoupling the package from the actual implementation.

sagikazarmark avatar Dec 30 '15 13:12 sagikazarmark

good idea. it should be part of a "migrating to httplug guide"

dbu avatar Dec 31 '15 11:12 dbu

Yes. The idea came from the fact that people might not get the idea of httplug, so they might not want to use it for various reasons. One of them can be breaking BC, which is clearly not necessary with this two-step migration.

sagikazarmark avatar Dec 31 '15 12:12 sagikazarmark

@sagikazarmark Can you open a PR for this?

ddeboer avatar Jan 03 '16 20:01 ddeboer

Will do.

sagikazarmark avatar Jan 03 '16 20:01 sagikazarmark

:+1:

_____________________________

From: Márk Sági-Kazár [email protected] Sent: zondag, januari 3, 2016 9:05 PM Subject: Re: [documentation] Migration: recommend a two step migration (#57) To: php-http/documentation [email protected] Cc: David de Boer [email protected]

Will do.

— Reply to this email directly or view it on GitHub.

ddeboer avatar Jan 03 '16 20:01 ddeboer