HttplugBundle icon indicating copy to clipboard operation
HttplugBundle copied to clipboard

Next Major: Make classes final where possible

Open dbu opened this issue 5 years ago • 1 comments

Q A
Bug? no
New Feature? no
Version BC breaking change: Next major

Classes like the factories are not final. We should go over the bundle and make everything final that is not explicitly intended to be extended. Also check for things with protected visibility and make them private where possible.

dbu avatar Mar 04 '19 16:03 dbu

For one of the next 1.x releases we can already flag these classes with the @final annotation in the class docblock. The DebugClassLoader from the Symfony Debug component will then raise a deprecation if someone extends these final classes without a hard break.

xabbuh avatar Mar 04 '19 18:03 xabbuh