simple-cache icon indicating copy to clipboard operation
simple-cache copied to clipboard

Corrected type hints

Open mindplay-dk opened this issue 8 years ago • 5 comments

Per this thread, I understand that tool support is not a concern or priority for the FIG, so I don't expect this PR will be merged - a replacement package with corrected type-hints has been published and can be installed as mindplay/simple-cache now.

mindplay-dk avatar Feb 01 '17 19:02 mindplay-dk

+1

The return type of return (array) $result; (array) is incompatible with the return type declared by the interface Psr\SimpleCache\CacheInterface::getMultiple of type Psr\SimpleCache\iterable.

I'm also getting this error. Any chance this will be merged? If I require mindplay/simple-cache then anything using psr/simple-cache will break making the whole spec kinda useless.

ghost avatar Mar 21 '17 16:03 ghost

If I require mindplay/simple-cache then anything using psr/simple-cache will break

It won't - my package replaces the real package and is otherwise identical to it.

But yeah, it would be nice if we didn't need this crappy work-around.

mindplay-dk avatar Mar 22 '17 11:03 mindplay-dk

@michaelcullum @dragoonis Is this PR mergeable ?? Thanks you :)

Geolim4 avatar Jun 24 '17 12:06 Geolim4

We should revisit the use of strong types, and flexible types, once the conversation around #13 is resolved. Afterward then we'll know what is and isn't possible, in terms off strict and flexible typing.

dragoonis avatar Apr 20 '20 16:04 dragoonis

Does this makes still sense in the light of #24 + #25?

Jean85 avatar Oct 06 '21 11:10 Jean85