enqueue-dev icon indicating copy to clipboard operation
enqueue-dev copied to clipboard

feat(GPS): allow send attributes in Google PubSub message.

Open p-pichet opened this issue 1 year ago • 4 comments

Allow to send PubSub attributes

p-pichet avatar May 06 '24 09:05 p-pichet

@makasim Can someone look at this PR please ?

p-pichet avatar Jun 12 '24 07:06 p-pichet

Hello @dgafka. Can you review this PR or tell me who can ?

p-pichet avatar Jun 20 '24 13:06 p-pichet

Hello @p-pichet I am not maintainer of this package, @makasim is ;)

dgafka avatar Jun 20 '24 13:06 dgafka

as i saw you approve some requests and i don't have any responses, i ask you but i understand.

p-pichet avatar Jun 21 '24 06:06 p-pichet

@makasim

p-pichet avatar Jul 02 '24 08:07 p-pichet

ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.

makasim avatar Jul 02 '24 09:07 makasim

ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.

i see why the CI is not trigger. You are agree with the modification ?

p-pichet avatar Jul 02 '24 09:07 p-pichet

I don't understand how to run CI.

p-pichet avatar Jul 02 '24 09:07 p-pichet

Hi @makasim, can you run CI actions, please?

p-pichet avatar Jul 02 '24 09:07 p-pichet

I cannot, I would do it if it were possible

makasim avatar Jul 02 '24 11:07 makasim

I hesitate if it was a trigger message. Do you know the condition to enable the CI ? Is it because my repository is not correctly setup ?

p-pichet avatar Jul 02 '24 12:07 p-pichet

CI has to be triggered on any MR by default without any additional actions from any side. There is one exception where a maintainer has to approve CI but there is none.

makasim avatar Jul 02 '24 12:07 makasim

Maybe try open a new PR from new branch, hope it helps

makasim avatar Jul 02 '24 12:07 makasim

@makasim i push a fix, can you run the CI please.

p-pichet avatar Jul 02 '24 14:07 p-pichet

@makasim i push a change, can you run the CI please.

p-pichet avatar Jul 05 '24 09:07 p-pichet

@makasim i push a change, can you run the CI please.

p-pichet avatar Jul 12 '24 14:07 p-pichet

@makasim I push a change, can you run the CI please. For the version 8.x of PHP, we got issue on the SQS, but I don't touch it. Who can have a look at it ?

p-pichet avatar Aug 01 '24 13:08 p-pichet

@makasim We found that the 404 error come from an update of aws/aws-sdk-php. Who is in charge of the maintenance of external lib ?

p-pichet avatar Aug 01 '24 13:08 p-pichet

@makasim I push a change, can you run the CI please.

p-pichet avatar Aug 06 '24 12:08 p-pichet

@makasim it's seem the image use to run CI not found the docker compose command.

p-pichet avatar Aug 06 '24 12:08 p-pichet

@makasim I push a change, can you run the CI please.

p-pichet avatar Aug 06 '24 13:08 p-pichet

And for information docker-compose has been remove https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md

p-pichet avatar Aug 06 '24 13:08 p-pichet

@makasim i push again please run the ci

p-pichet avatar Aug 07 '24 07:08 p-pichet

@makasim can you run the CI please ?

p-pichet avatar Aug 07 '24 08:08 p-pichet

You can ping me instead :sweat_smile:

I've ran most of your requests recently :)

Steveb-p avatar Aug 07 '24 09:08 Steveb-p

thanks @Steveb-p . Have you see my other messages ?

p-pichet avatar Aug 07 '24 14:08 p-pichet

thanks @Steveb-p . Have you see my other messages ?

Yeah, but I'm mostly in the same situation as you are. I was mostly involved in rdkafka itself when I was working on queues in my old job, and can't really help with those custom docker images :confounded:

Steveb-p avatar Aug 07 '24 15:08 Steveb-p

@Steveb-p can you run the CI please

p-pichet avatar Aug 08 '24 08:08 p-pichet

@Steveb-p i try something can you run the CI ?

p-pichet avatar Aug 08 '24 15:08 p-pichet

@Steveb-p and @makasim, the CI fail on the SQS and SNS. We don't have strong knowledge to understand what happen. do you have a name to someone can help use ? Maybe @ASKozienko as you work on the failing test.

p-pichet avatar Aug 09 '24 07:08 p-pichet