enqueue-dev icon indicating copy to clipboard operation
enqueue-dev copied to clipboard

Bugfix in `RdKafkaProducer:flush()` method

Open alexbusu-motork opened this issue 1 year ago • 8 comments

Avoid TypeError in RdKafkaProducer::flush()

alexbusu-motork avatar Apr 03 '24 15:04 alexbusu-motork

It seems there is an issue with localstack deployment, because after the services are up, one of them (the one on port 4576) shuts down. All of the http requests to service healtcheck curl -i http://localhost:4576/_localstack/health will return 404 :shrug: What I've tried is to change the localstack image version, by downgrading and upgrading the patch, minor and major versions, but still no luck in having it working. I notice that this issue happens in other PRs as well. @makasim @Steveb-p please help with this issue.

alexbusu-motork avatar Apr 05 '24 15:04 alexbusu-motork

@makasim @Steveb-p please help with this issue.

I can review PR and merge green one. Release a new version. That's it. So, don't expect me to fix failing CI.

makasim avatar Apr 08 '24 06:04 makasim

@makasim ok, please let me know - since this is a failing component of testing stage (not related to the code quality/functionality itself) - who could help me with this issue? I mean, who is maintaining the functional tests environment, so we can check together?

alexbusu-motork avatar Apr 08 '24 09:04 alexbusu-motork

Contributors, like you.

makasim avatar Apr 08 '24 10:04 makasim

@makasim please run the workflow. I've brought some changes.

alexbusu-motork avatar Apr 08 '24 14:04 alexbusu-motork

@makasim please run the workflow again.

alexbusu avatar Jun 18 '24 09:06 alexbusu

@makasim please run the workflow.

alexbusu avatar Jun 19 '24 10:06 alexbusu

Now the only failing test is Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test():

Failed asserting that null is an instance of interface "Interop\Queue\Message".

https://github.com/php-enqueue/enqueue-dev/actions/runs/9580921964/job/26416695363?pr=1347#step:10:266

@makasim @Steveb-p it's not clear to me why this fails here; it is not failing when I run for the same environment on my local machine. What would you suggest, what should I try?

alexbusu avatar Jun 19 '24 12:06 alexbusu