enqueue-dev icon indicating copy to clipboard operation
enqueue-dev copied to clipboard

Bump symfony from 6.0 to 6.4 and add support for 7.0

Open snapshotpl opened this issue 2 years ago • 5 comments

snapshotpl avatar Dec 15 '23 10:12 snapshotpl

@snapshotpl are you make the changes to this branch with the feedback? Or what is your planning?

TechComBiz avatar Jan 01 '24 17:01 TechComBiz

@VincentLanglet I waiting for this future. So, I have fix your comments in a PR to the code of snapshotpl. Only, I am new here so I don't know if I do it right: https://github.com/snapshotpl/enqueue-dev/pull/1

And If snapshot react not quick. Is it then better to make a new PR?

TechComBiz avatar Jan 03 '24 07:01 TechComBiz

And If snapshot react not quick. Is it then better to make a new PR?

It seems better indeed because there is still a lot of work. Look at https://github.com/php-enqueue/enqueue-dev/pull/1330, lot of build are failing...

If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.

VincentLanglet avatar Jan 03 '24 09:01 VincentLanglet

And If snapshot react not quick. Is it then better to make a new PR?

It seems better indeed because there is still a lot of work. Look at #1330, lot of build are failing...

If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.

I have make an own https://github.com/php-enqueue/enqueue-dev/pull/1331 Please, give feedback :)

TechComBiz avatar Jan 03 '24 12:01 TechComBiz

any update on this?

AlexOstrovsky avatar Jan 19 '24 07:01 AlexOstrovsky