enqueue-dev icon indicating copy to clipboard operation
enqueue-dev copied to clipboard

Add `void` return type in DoctrineSchemaCompilerPass and MessageQueueCollector

Open ruudk opened this issue 2 years ago • 6 comments

Fixes these deprecations on Symfony 6.3:

Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Doctrine\DoctrineSchemaCompilerPass" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::collect()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Bundle\Profiler\MessageQueueCollector" now to avoid errors or add an explicit @return annotation to suppress this message.

ruudk avatar Aug 17 '23 07:08 ruudk

@makasim This one is ready for review.

ruudk avatar Aug 17 '23 07:08 ruudk

@makasim I fixed the CS error. If you approve, it's going to be green. Except for 1 failing test that is out of my control. Could you please merge this? Thanks.

ruudk avatar Aug 17 '23 11:08 ruudk

Unfortunately, I cannot merge the red build, If it makes to the main it will stay there for a long time, making the whole idea of testing and CI useless.

makasim avatar Aug 17 '23 11:08 makasim

Main is already red: https://github.com/php-enqueue/enqueue-dev/commits/master

The error on this PR is the same, so that's what I mean.

Obviously this PR doesn't create new errors 😅

ruudk avatar Aug 17 '23 11:08 ruudk

I give up. The errors in this PR are unrelated to my changes.

ruudk avatar Aug 17 '23 12:08 ruudk

This fails because this project uses PHPStan 0.12, which is outdated. It should be updated to PHPStan ^1.8.

ruudk avatar Oct 22 '23 16:10 ruudk