enqueue-dev icon indicating copy to clipboard operation
enqueue-dev copied to clipboard
verified publisher icon php-enqueue

[amqp-ext] Passing null to parameter is deprecated.

Open EmilMassey opened this issue 3 years ago • 5 comments

Fixes deprecation notice Deprecated: AMQPQueue::consume(): Passing null to parameter #3 ($consumer_tag) of type string is deprecated in

EmilMassey avatar Nov 07 '22 12:11 EmilMassey

I did not change the line reported by the code style check in this PR. I fixed that in a separate PR #1276

EmilMassey avatar Nov 09 '22 11:11 EmilMassey

Nice change for 8.1 compatibility, can we have this merged please @makasim

nightlinus avatar Dec 11 '22 08:12 nightlinus

Nice change for 8.1 compatibility, can we have this merged please @makasim

Indeed, once all tests are green

makasim avatar Dec 11 '22 11:12 makasim

Nice change for 8.1 compatibility, can we have this merged please @makasim

Indeed, once all tests are green

The failures seem to be unrelated to my changes (403 from AWS). Can you please take a look? Maybe they need to be rerun?

EmilMassey avatar Dec 11 '22 13:12 EmilMassey

Sorry, I am not going to look into it. I don't use the library nor write in PHP.

I can review and merge when everything is green, and release it.

makasim avatar Dec 11 '22 17:12 makasim