polyfill icon indicating copy to clipboard operation
polyfill copied to clipboard

polyfill is not a drop-in replacement for php extension

Open muawijhe opened this issue 5 years ago • 2 comments

Hi!

I just released a library to handle Tree data structures using Ds Deque class ho handle dynamic increase/decrease of childrens.

What I found interesting is the following:

  • before installing the extension on TravisCI unit-tests didn't work
  • after installing the extension everything came back to normal.

During the development I used the extension, perhaps because I am a bit nostalgic of C++ routines and also because I believe that it is more efficient as behind the hood uses dynamic lists instead of php arrays...

However, I cannot find the problem at the moment, but I start by creating this issue.

Later I'll try myself to dig inside your project to understand why I got an infinite recursion when using Php version instead of C++ extension.

For the ones interesting in the library I was talking about, have a look here:

https://github.com/calabrothers/php-ds-tree

With my best regards

muawijhe avatar Jan 19 '20 23:01 muawijhe

Hi @muawijhe, do you have any further information about this?

rtheunissen avatar May 07 '20 22:05 rtheunissen

Hi Rudi Thanks for your reply, it is easy to verify what function is not compliant with the c++ module.

Just ru the unit test of the project:

https://github.com/calabrothers/php-ds-tree

With the c++ module it works while with your php replacement didn't.

I believe there is a discrepancy between functionality on data structure when handlers are used.

V.

On Fri, May 8, 2020, 12:50 AM Rudi Theunissen [email protected] wrote:

Hi @muawijhe https://github.com/muawijhe, do you have any further information about this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/php-ds/polyfill/issues/59#issuecomment-625536080, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVO6GUNDLSVTUAIT7DFDS3RQM3MPANCNFSM4KI4HSTA .

muawijhe avatar May 08 '20 10:05 muawijhe