mystamps icon indicating copy to clipboard operation
mystamps copied to clipboard

Reduce number of unit tests

Open php-coder opened this issue 1 year ago • 0 comments

Check list:

  • [ ] #1145 needs a decision
  • [ ] will drastically reduce a scope of #1246
  • [ ] check the current tests and remove non-usefull
    • [ ] SlugUtilsTest.groovy
    • [ ] LocaleUtilsTest.groovy
    • [ ] PagerTest.groovy
    • [x] SeriesSalesServiceImplTest.groovy (resolution: fully remove)
    • [ ] CatalogUtilsTest.groovy
    • [x] StampsCatalogServiceImplTest.groovy (resolution: fully remove)
    • [x] SeriesSalesImportServiceImplTest.groovy (resolution: fully remove)
    • [ ] SeriesInfoExtractorServiceImplTest.groovy
    • [x] TimedSeriesInfoExtractorServiceTest.groovy (resolution: fully remove)
    • [x] SeriesImportServiceImplTest.groovy (resolution: remove most of the tests)
      • [x] keep addRequest() should throw exception if url is incorrect
      • [x] keep addRequest() should save url in the encoded form
      • [x] keep addRequest() should not encode url if it is already encoded
    • [x] SeriesServiceImplTest.groovy (resolution: remove most of the tests)
      • [x] keep add() should remove image when exception occurs
      • [x] keep addImageToSeries() should remove image when exception occurs
    • [x] CollectionServiceImplTest.groovy (resolution: fully remove)
    • [x] CategoryServiceImplTest.groovy (resolution: fully remove)
    • [x] ParticipantServiceImplTest.groovy (resolution: fully remove)
    • [ ] FilesystemImagePersistenceStrategyTest.groovy
    • [x] ImageServiceImplTest.groovy (resolution: remove most of the tests)
      • [x] keep save() should pass content type '#contentType' to image dao (but rename it and emphasize testing of conversion logic)
      • [x] keep save() should pass abbreviated filename when it is too long
    • [x] TimedImagePreviewStrategyTest.groovy (resolution: fully remove)
    • [ ] DatabaseImagePersistenceStrategyTest.groovy
    • [x] SiteServiceImplTest.groovy (resolution: remove most of the tests)
      • [x] keep logEvent() should pass abbreviated method when it's too long
      • [x] keep logEvent() should pass abbreviated referer when it's too long
      • [x] keep logEvent() should pass abbreviated user agent when it's too long
      • [x] keep logAboutAbsentPage() should pass abbreviated page when it's too long
    • [ ] CronServiceImplTest.groovy
    • [ ] SuspiciousActivityServiceImplTest.groovy
    • [ ] UsersActivationServiceImplTest.groovy
    • [x] UserServiceImplTest.groovy (resolution: fully remove)
    • [x] CountryServiceImplTest.groovy (resolution: fully remove)
    • [ ] JsoupSiteParserTest.java
    • [ ] JdbcCategoryDaoTest.java
    • [ ] JdbcCountryDaoTest.java
    • [ ] ContentSecurityPolicyHeaderWriterTest.java
  • [ ] remove unused methods from TestObjects, Random and DateUtils classes
  • [ ] close issues for adding more unit tests
    • [ ] check @todo comments
      • [x] #579
      • [x] #757
      • [x] #800
      • [x] #805
      • [x] #825
      • [x] #827
      • [x] #902
      • [x] #923
      • [x] #1028
      • [x] #1194
      • [x] #1271
      • [x] #1318
      • [x] #1366
      • [x] #1373
      • [x] #1423
      • [x] #1430
      • [x] #1433
      • [x] #1436
      • [x] #1614
      • [x] #1629
      • [x] #1630
    • [ ] find issues created manually
    • [ ] close related issues
      • [x] #746
      • [x] #926
  • [ ] remove comments like protected for using in unit tests

php-coder avatar Feb 07 '24 13:02 php-coder