Slava Semushin comments

Results 149 comments of


                                            Slava Semushin

Publish playbook for production

Need to find a way to commit prod.inventory file as well.

When user adds series to a collection he should be able to specify its condition

Not only cancellation but any condition (MNH, CTO, etc)

CI: validate and check Terraform configuration

We can run `terraform fmt -check -diff` and `terraform validate`.

CI: validate and check Terraform configuration

See also https://github.com/hashicorp/setup-terraform

Detect usage of the strings for numeric/boolean types in Liquibase migrations

Another case that hasn't been spotted in #1107: ```xml ```

Detect usage of the strings for numeric/boolean types in Liquibase migrations

It seems like we can use `git grep value="\d+"` for finding `valueNumeric` candidates and `git grep value="TRUE|true|FALSE|false"` for `valueBoolean`

Detect usage of the strings for numeric/boolean types in Liquibase migrations

Another idea is to detect usage of old schema: http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd instead of 3.1

Detect usage of the strings for numeric/boolean types in Liquibase migrations

Yet another one: each `` must have `context` attribute with supported values.

Detect usage of the strings for numeric/boolean types in Liquibase migrations

One more gotcha -- MySQL doesn't support `beforeColumn` -- https://liquibase.jira.com/browse/CORE-2347

Detect usage of the strings for numeric/boolean types in Liquibase migrations

We can also force a foreign keys to have a name. Also we can check that date fields have names with suffix "_at" and fields that references users have suffix...