docker-php-censor icon indicating copy to clipboard operation
docker-php-censor copied to clipboard
verified publisher icon php-censor

Testing and CI for image

Open ketchoop opened this issue 8 years ago • 4 comments

ketchoop avatar Feb 03 '17 21:02 ketchoop

How can I assign this ticket to myself?

ptejada avatar Jan 11 '19 04:01 ptejada

@ptejada Done.

corpsee avatar Jan 11 '19 04:01 corpsee

I tried the installation in Windows with the Docker Toolbox v18.03. The installation went smoothly.

A few things that can be improved:

  1. Upgrade the docker composer file version to 3.
  2. Providing DB options is unnecessary. It should be assumed that if the consumer will be using the DB it will only be used for the PHP Censor software. If the consumer requires a specific DB they should provide it to the worker.
  3. By default, the DB container should be set up with a volume for storage. Otherwise, the database is lost when the container is disposed or rebuild.

Things I did not test:

  • Large test suites.
  • Multi worker and running build in parallel.

ptejada avatar Jan 12 '19 07:01 ptejada

@ptejada Thank you for the massive testing! :+1: Could you create issues or PRs for all your points please?

corpsee avatar Jan 12 '19 09:01 corpsee