rawkit icon indicating copy to clipboard operation
rawkit copied to clipboard

Invalid raw.data.contents.color.rgb_cam?

Open pkorus opened this issue 6 years ago • 1 comments

I'm writing my own RAW development procedure, and I encountered a potential problem with the sRGB conversion matrix as reported by rawkit. Specifically, the array returned by raw.data.contents.color.rgb_cam is:

[[ 1.82691061 -0.65497452 -0.17193617]
 [ 0.         -0.00683982  1.33216381]
 [-0.32532394  0.          0.06269717]
 [-0.40055895  1.33786178  0.        ]]

And it should be (as correctly reported by a different ctypes-based libraw wrapper).

[[ 1.8269106  -0.6549745  -0.17193617  0.        ]
 [-0.00683982  1.3321638  -0.32532394  0.        ]
 [ 0.06269717 -0.40055895  1.3378618   0.        ]]

It would appear that the array dimensions are swapped somewhere.

pkorus avatar Aug 15 '18 19:08 pkorus

I'm not surprised, there are lots of features we haven't fully tested. I'm not actively working on this library anymore, but if you open a PR with a fix we'll merge it.

campaul avatar Sep 18 '18 03:09 campaul