vue icon indicating copy to clipboard operation
vue copied to clipboard

Fixed #23 webpack error stating no appropriate loaders

Open davidmahbubi opened this issue 2 years ago • 2 comments

davidmahbubi avatar Jul 07 '22 08:07 davidmahbubi

@davidmahbubi I believe it is not recommended to commit the compiled files because someone can inject malicious code inside the compiled script. It is impossible for a human to review these compiled files.

ph7jack avatar Jul 20 '22 04:07 ph7jack

So how can we fix the loader issue ?

OualiS avatar Aug 14 '22 14:08 OualiS

Since the a new major version of the library is in the works that uses a very different build system (Vite 4) this issue should be solved. Feel free to have a look at it in the next branch, or try it out by installing @phosphor-icons/vue@next in your project.

Your PR seems to have changed all components from using the the nullish coalescing operator to the OR operator. Note that this is not correct, since the OR operator uses the right hand value as soon as the left hand value is falsy. This means that it would also fall back to the injected values when a size is 0 for example, which should not be valid behavior since the user explicitly set the size to 0 for a reason.

dnlsndr avatar Feb 04 '23 11:02 dnlsndr