Phil Hord

:+1:

Atomic operations aren't bad if they are kept relatively brief. You do need to protect the assignment or comparison (generally) of any 16-bit or larger value. Your experimental version tries...

Ah, you're right. Currently dda_join_moves is only called from dda_create and `current` is always an unstarted movement. But the comments on both locations (caller and callee) suggest this is expected...

You do need the atomic at the end. On Wed, Nov 16, 2016, 10:46 PM Nico Tonnhofer [email protected] wrote: > I went yesterday a more radical way and removed any...

Disabling motors on startup might allow some mechanics to slide when disaster strikes. When the controller resets due to brownout or some code error, for example, the motors might suddenly...

@mattgilbertnet If your motors are whining you might have too much power going to them. It's a delicate balance to try to achieve. If your motors do not get hot...

@nythil Thanks for being receptive to my comments. I'm still a bit unsettled, though. I think this patch (fd84e04ece95250181f10d71722a0e211e279b9f) makes the change cleaner, but I have not tested it. Does...

Is there any reason we can't just standardize on 250ms temp conversion intervals so we can avoid all the individual timers? 000 ms init 250 ms ADC kick if needed...

> > And heater->set would still be called in 250ms intervals. > > No, heater is called, when the temp is ready. Just behind the last read of a 250ms...

How about this: 68881b030b601b28476e075e1a426d98e6256710 Sorry about all the refactoring noise. I intended to save that for later, but it got mixed in.