Patrick Hoefler

Results 345 comments of Patrick Hoefler

Thanks for the report. Could you add a bit more context about what you are trying to achieve with attr? attr doesn't really work in pandas either and support is...

This is non-trivial to add and the semantics aren't completely clear either. This can't live on the collection level, it has to be on the expression level since we are...

That would be fine but this still doesn't cover what should happen after df.optimize() is called, which is the tricky part here

> can you elaborate? My initial gut reaction is that this should only live on the collection level and not on expr. We constantly re-create the expressions underneath the collection,...

I currently don't have enough bandwidth to take this on. This would need someone from the community taking a look at it and providing a first PR for it.

Hi, sorry for the slow review. Could I ask you to separate typing changes and doc changes into another PR so that we can focus on the actual code changes...

You can also just roll back the typing stuff. The point of this is that we want to keep the focus of a PR narrow. This PR has lots of...

Ah yikes, I missed that ping. This sounds like a shuffle - map_blocks problem now that we have a shuffle. I'll take a closer look though

Hi Thanks for opening the issue! This sounds interesting to me. Are you interested in writing something up?