phoenix_live_view icon indicating copy to clipboard operation
phoenix_live_view copied to clipboard

Make all comprehensions keyed, don't rely on LiveComponents

Open SteffenDE opened this issue 6 months ago • 1 comments

This changes keyed comprehensions to not rely on LiveComponents any more. It is very much work in progress.

TODOs:

  • [ ] fix template duplication when rendering new items
  • [ ] fix tests that still expect regular comprehensions
  • [ ] remove(?) Phoenix.LiveView.Comprehension
  • [ ] write more tests
  • [ ] write comprehensive documentation about the diff format

SteffenDE avatar Jun 27 '25 17:06 SteffenDE

cc @josevalim

SteffenDE avatar Jun 28 '25 18:06 SteffenDE

@josevalim I checked the stream docs and I think they are fine as is. I pushed some other docs changes here: https://github.com/phoenixframework/phoenix_live_view/pull/3865/commits/958343a0c66c2ec6f37b93fd5164493a1b740ec9

SteffenDE avatar Jul 03 '25 22:07 SteffenDE

I also want to expand the diff documentation a bit when I find the time.

SteffenDE avatar Jul 03 '25 22:07 SteffenDE

@SteffenDE not planned for 1.1?

AlexKovynev avatar Jul 05 '25 03:07 AlexKovynev

It’s going to be backported to the 1.1 branch and a new RC will ship soon :)

SteffenDE avatar Jul 05 '25 06:07 SteffenDE