phoenix_live_view icon indicating copy to clipboard operation
phoenix_live_view copied to clipboard

Published 20 hours ago • verified publisher icon phoenixframework

Add data and aria to globals

Open nathany-copia opened this issue 1 year ago • 3 comments

resolves #2217

nathany-copia avatar Sep 22 '22 16:09 nathany-copia

If we were to merge this, then I think we should also support aria. But I am also fine with telling people to use data-* and aria-*.

josevalim avatar Sep 22 '22 17:09 josevalim

added aria

nathany-copia avatar Sep 22 '22 20:09 nathany-copia

For our use case, we ended up transitioning to data-* because we only have a single attribute, but others may have a reason to pass a larger keyword list to data.

nathany-copia avatar Sep 23 '22 16:09 nathany-copia

We're going to wait on this one. It may make sense in the future to merge, but I'd like to see how common it is in the wild first as folks write more components. Thanks!

chrismccord avatar Feb 10 '23 15:02 chrismccord

👌🏻 pretty sure we worked around it

nathany-copia avatar Feb 10 '23 16:02 nathany-copia