phoenix_live_dashboard icon indicating copy to clipboard operation
phoenix_live_dashboard copied to clipboard

Counter charts should not display a unit

Open mcrumm opened this issue 5 years ago • 4 comments

The unit label on the y-axis and in the legend is confusing for a counter, since the values are simply positive whole numbers.

mcrumm avatar Apr 16 '20 04:04 mcrumm

from https://github.com/phoenixframework/phoenix_live_dashboard/issues/30#issuecomment-603142645 it sounds like you guys ditched donut charts for x/y plots? that's quite the change, considering how differently they show data. unless you're needing to show the counter progression over time, you might want to just DIY the donut charts via a sprinkle of SVG:

https://akzhy.com/blog/create-animated-donut-chart-using-svg-and-javascript/

uPlot is definitely not the hammer for every nail :P

although without seeing what you're referring to, i'm possibly inferring a lot of wrong stuff, heh.

leeoniya avatar Apr 16 '20 04:04 leeoniya

Hi @leeoniya!

For more context, we're using uPlot to visualize data from Telemetry.Metrics. We're still in the very early stages of this implementation, so starting with a generic timeseries chart for all metrics types, given the performance improvements, seemed preferable for the time being.

That said, thank you very much for the link! ❤️ It's given me some new ideas :)

mcrumm avatar Apr 16 '20 05:04 mcrumm

And for completeness, we should also ignore the value and keep a counter on the client.

josevalim avatar Apr 26 '20 15:04 josevalim

we should also ignore the value and keep a counter on the client

That's how it's done now - counter increments by one for each event and sum increments by the y value.

mcrumm avatar Apr 26 '20 18:04 mcrumm