phoenix_live_dashboard icon indicating copy to clipboard operation
phoenix_live_dashboard copied to clipboard

Time aggregation for metrics charts?

Open cheerfulstoic opened this issue 3 years ago • 1 comments

Environment

Make sure you are using the latest LiveView and Dashboard versions before continuing.

  • Elixir version (elixir -v): 1.11.3
  • Phoenix version (mix deps): ~> 1.5.8
  • Phoenix LiveView version (mix deps): ~> 0.15.1
  • Phoenix Dashboard version (mix deps): ~> 0.4
  • Operating system: MacOS 11.1
  • Browsers you attempted to reproduce this bug on (the more the merrier): Firefox

Actual behavior

Metrics display as exact point-in-time. That is, if I send two telemetry event right next to each other as a summary metric, the value is always just 1.

Expected behavior

I expected it to automatically roll-up my metrics every x seconds (maybe every 1 or 5 seconds). So if 3 requests were made within a 5 second period, the line in the chart would be at 3.

This is mainly an inquiry of: would this be a welcome change if I were to make a PR? Does it seem like it would be very difficult?

cheerfulstoic avatar Apr 10 '21 14:04 cheerfulstoic

Summary is supposed to show average and other metrics, so if that is not behaving as you expect, then a PR is definitely welcome!

josevalim avatar Apr 10 '21 14:04 josevalim