flame icon indicating copy to clipboard operation
flame copied to clipboard

Set the Runner `:timeout` option to the maximum between itself and the `:boot_timeout`

Open probably-not opened this issue 11 months ago • 1 comments

Currently, the :timeout and :boot_timeout are separate options - however, when running something that has a long :boot_timeout set, you must know to set the :timeout option to the same time (or longer), otherwise, the FLAME.call function calls will fail with a timeout even if the boot has not completed.

This PR sets the :timeout option to be the maximum between the :timeout and the :boot_timeout, to ensure that a timeout cannot happen before a boot_timeout happens.

probably-not avatar Jan 07 '25 19:01 probably-not

Currently, the :timeout and :boot_timeout are separate options - however, when running something that has a long :boot_timeout set, you must know to set the :timeout option to the same time (or longer), otherwise, the FLAME.call function calls will fail with a timeout even if the boot has not completed.

This PR sets the :timeout option to be the maximum between the :timeout and the :boot_timeout, to ensure that a timeout cannot happen before a boot_timeout happens.

That sounds like it's worth a mention in documentation

lessless avatar Jul 18 '25 08:07 lessless