esbuild icon indicating copy to clipboard operation
esbuild copied to clipboard

Published 20 hours ago • verified publisher icon phoenixframework

Move esbuild to the NPM @esbuild scope

Open cw789 opened this issue 2 years ago • 4 comments

This is my take on https://github.com/phoenixframework/esbuild/issues/52. It's not ready until the new breaking version number of esbuild is known for sure.

cw789 avatar Sep 05 '22 12:09 cw789

Looks great! A couple notes:

  1. Let's bump the esbuild version once the release is out
  2. Let's update the manual install instructions in Esbuild moduledoc :)

josevalim avatar Sep 07 '22 09:09 josevalim

  1. Totally agree - will do
  2. Good point - will do

Found one more issue with my solution. target() is used in bin_path() → https://github.com/phoenixframework/esbuild/blob/main/lib/esbuild.ex#L128 Means nearly everyone needs to reinstall via mix esbuild.install...

I could additionally do a Version.compare/2 in bin_path() or one in target() and move legacy targets to the target() function.

cw789 avatar Sep 07 '22 11:09 cw789

Means nearly everyone needs to reinstall via mix esbuild.install...

Well, they will have to reinstall once they change the version or update this package with a new version, so that's ok. :)

josevalim avatar Sep 07 '22 12:09 josevalim

Right, sounds good. Thank you.

cw789 avatar Sep 07 '22 12:09 cw789

❤️❤️❤️🐥🔥

chrismccord avatar Dec 09 '22 16:12 chrismccord