Phoebus Mak
Phoebus Mak
Pending corresponding patch for conda environment. Conda does not support patching sources locally
https://github.com/Azure/azure-sdk-for-cpp/pull/4982 Awaiting above PR so that the pin of Azure C++ SDK on Conda can be updated
> [Azure/azure-sdk-for-cpp#4982](https://github.com/Azure/azure-sdk-for-cpp/pull/4982) Awaiting above PR so that the pin of Azure C++ SDK on Conda can be updated PR merged. Awaiting Azure SDK pin being updated on conda feedstock
https://github.com/Azure/azure-sdk-for-cpp/pull/4982#issuecomment-1741187849 ``` ...this change should be available on vcpkg at some time next week with the October release of the Azure SDK. ```
This PR will be put on-hold as https://github.com/Azure/azure-sdk-for-cpp/pull/4982#issuecomment-1743808598 stated that the PR on Azure SDK won't be officially release until 10th Nov.
- `sort_merge` -> `sort_merge_internal`: prune_previous not available - `sort_index`: prune_previous not available - `delete_range` -> `delete_range_internal`: prune_previous not available - `defragment_symbol_data`: prune_previous not available
Spoken to @jamesmunro regarding this ticket. We settle with the return value to be `Optional[VersionedItem]` but the discussion is not closed yet.
> Change looks fine. What test coverage do we have for our SSL interaction? https://github.com/man-group/ArcticDB/pull/1338 S3 auto ca path PR has already been merged. It contains the https related tests....
> Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not. @poodlewars It is on now.
@poodlewars ``` root@XPS:/tmp# cat /etc/*-release | grep PRETTY_NAME PRETTY_NAME="Ubuntu 22.04.4 LTS" root@XPS:/tmp# python -m venv venv root@XPS:/tmp# source venv/bin/activate (venv) root@XPS:/tmp# pip install arcticdb-4.1.0.dev0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (venv) root@XPS:/tmp# python Python 3.10.12 (main,...