phoebe2 icon indicating copy to clipboard operation
phoebe2 copied to clipboard

lc_geometry propose compute_phases to cover eclipses more heavily

Open kecnry opened this issue 1 year ago • 3 comments

Original algorithm written by @piotrkolaczekszymanski and @amiszuda

TODO:

  • [ ] Current test example is proposing compute_phases of [0, 1] which is clearly incorrect. Investigate this.
  • [ ] Test coverage
  • [ ] Documentation

kecnry avatar Jun 13 '24 07:06 kecnry

It is actually an algorithm originally written by Piotr Kołaczek-Szymański (not on GitHub) with some changes.

amiszuda avatar Jun 13 '24 08:06 amiszuda

Ah yes, I'm in the room with new GitHub user @piotrkolaczekszymanski right now 😂

kecnry avatar Jun 13 '24 08:06 kecnry

It is actually an algorithm originally written by Piotr Kołaczek-Szymański (not on GitHub) with some changes.

Wrong, we got him onto github a few days ago! :)

aprsa avatar Jun 13 '24 09:06 aprsa