protest icon indicating copy to clipboard operation
protest copied to clipboard

Backwards incompatible change in DEFINE-PROTOCOL-CLASS

Open phoe opened this issue 5 years ago • 1 comments

Currently, PROTEST/BASE:DEFINE-PROTOCOL-CLASS defines a method on INITIALIZE-INSTANCE. This is buggy, since this means that it is still possible to create instances of the protocol class by e.g. using CHANGE-CLASS. This means that, in the future, DEFINE-PROTOCOL-CLASS will also define methods on UPDATE-INSTANCE-FOR-REDEFINED-CLASS to prevent such.

This issue is a warning to all clients of this method to ensure that they do not have. It's unlikely to have them, since changing classes to/from protocol classes is a weird thing to do, but I nonetheless post this here.

phoe avatar Jul 07 '20 22:07 phoe

22:30 < Bike> but you can still change-class to the protocol class! mwa ha HA!
22:30 < phoe> :O
22:30 < phoe> oh my
22:30 < jmercouris> well, of course you can even override the macro if you so desire
22:30 < jmercouris> I could change package, and redefine the macro
22:30 < jmercouris> that is however not the spirit of the package...
22:33 < Bike> i guess you could put a before/after method on update-instance-for-different-class to be 
              really particular about it

phoe avatar Feb 01 '21 21:02 phoe