phlask-map icon indicating copy to clipboard operation
phlask-map copied to clipboard

Refactor resource modal

Open ravimakhijapi opened this issue 1 year ago • 0 comments

Pull Request

Change Summary

Integrates the desktop and mobile component code for the Resource modal under a common directory and uses a more consistent approach. Previously, the mobile component was in src/components/ResourceMenu, but now both desktop and mobile versions are in src/components/ChooseResource.

Change Reason

It seemed confusing to have the resource modal for desktop and mobile in different places, named differently (e.g. ChooseResource vs. ResourceMenu), and using different approaches. The hotfix in #421 addressed the mobile resource modal regression, and this new PR provides a more robust solution by refactoring the related code for clarity.

Related Issue: #422, #401

ravimakhijapi avatar May 09 '24 13:05 ravimakhijapi