phlask-map icon indicating copy to clipboard operation
phlask-map copied to clipboard

Tune how filter values are passed back into ReactGoogleMaps

Open gcardonag opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. Currently, active filters are defined in the ReactGoogleMaps component and then adjusted via the Filter component. When updating the filters, which are stored in a 2-dimensional array, we force the ReactGoogleMaps component to update via the following approach to defining part of the component's state: activeFilterTags: JSON.parse(JSON.stringify(noActiveFilterTags)),

We would like to explore if there is a more efficient way to re-render this component based on changes to the filter. Part of this could include refactoring this component to be functional in order to make use of more modern ways to force redrawing the component.

Describe the solution you'd like There is no specific solution in mind as long as the challenge above is resolved in a way to simplifies how redrawing the ReactGoogleMap component based on changes to the filter.

Describe alternatives you've considered N/A

Additional context N/A

gcardonag avatar Sep 27 '23 00:09 gcardonag

This will be part of my new data schema PR #433

vontell avatar May 28 '24 23:05 vontell

@vontell is making a big PR related to the new data schema that will address this issue soon.

tomporvaz avatar May 28 '24 23:05 tomporvaz