phlask-map icon indicating copy to clipboard operation
phlask-map copied to clipboard

Create V.2 MapMarkers

Open dibleauzah opened this issue 4 years ago • 13 comments

Is your feature request related to a problem? Please describe. As we prepare to deploy PHLASK 2.0, we would like to update our markers to use the new designs prepared by our design team.

Describe the solution you'd like We would like the map markers displayed for all of our resources to match the designs listed here: https://www.figma.com/file/VGGqwl3Eq3GQIAO9I6LoNW/PHLASK?node-id=4550%3A31103&t=rE3z6jHsaxqt5JTG-1

Describe alternatives you've considered n/a

Additional context n/a

dibleauzah avatar Dec 12 '21 12:12 dibleauzah

Note to self: displaying the PHLASK Tap pins on the map

affabillyty avatar Dec 15 '21 00:12 affabillyty

The map pins have not been designed yet. If you want to start on this, I suggest removing the differently colored phlask-icons for water taps and implementing the following pins only:

  • water (drop icon), color: blue
  • food, color: orange
  • toilets, color: grey
  • foraging, color: green

lisapancakes avatar Jan 26 '22 00:01 lisapancakes

As a part of this, we would like to also be able to render Foraging and Bathroom-type data on the map. We'll need to add new IndieXMarker-type and MapMarkersX-type Components to handle those two cases. We can follow the similarly-named components in the project as a starting point and add references to the MapMarkersX-type components to the MapMarkersMapper component.

gcardonag avatar May 23 '23 23:05 gcardonag

Daniel Cha is picking this ticket up but does not have a github account in project yet.

tomporvaz avatar Dec 13 '23 00:12 tomporvaz

SVGs of the pins are in this google drive folder, and the filenames begin with pin.

tomporvaz avatar Dec 20 '23 00:12 tomporvaz

@a-maci29 to help @DancyyDev navigate code

tomporvaz avatar Jan 03 '24 00:01 tomporvaz

For the food icons, there are many different icons that pop up, are we consolidating all the food icons into one icon? @tomporvaz @freelyPheobe

DancyyDev avatar Jan 17 '24 22:01 DancyyDev

Needs help from design.

tomporvaz avatar Feb 07 '24 00:02 tomporvaz

@gcardonag to add bathroom and foraging data to test dbs for testing purposes.

tomporvaz avatar Feb 07 '24 00:02 tomporvaz

So far, everything is running smoothly. Image being replaced for foraging and database needs to still be connected.

freelyPheobe avatar Mar 06 '24 00:03 freelyPheobe

working on adding the active pin as well.

tomporvaz avatar Mar 19 '24 23:03 tomporvaz

Half complete. Foraging and Bathroom pins are not added yet, and these types cannot be verified without data. This work can continue when #399 is complete.

tomporvaz avatar Apr 02 '24 23:04 tomporvaz

Still blocked, but a big PR related to the Data schema coming soon may resolve this issue, or at least unblock it.

tomporvaz avatar May 28 '24 23:05 tomporvaz

Hey @DancyyDev ! We're just digging through some of our v2 ticket backlog and saw this. Is there any help/support you'd like with the work you've been doing here?

gcardonag avatar Sep 03 '24 23:09 gcardonag

@DancyyDev disregard this! We'll close this in favor of https://github.com/phlask/phlask-map/issues/386 (but offer is still open to support!)

gcardonag avatar Sep 03 '24 23:09 gcardonag