wlmaker icon indicating copy to clipboard operation
wlmaker copied to clipboard

wlroots 0.18 support

Open diederikdehaas opened this issue 1 year ago • 5 comments

wlroots 0.18 has been released: https://gitlab.freedesktop.org/wlroots/wlroots/-/releases/0.18.0

And in Debian there's a transition tracker for it, so it would be great if wlmaker would support wlroots 0.18 too.

diederikdehaas avatar Aug 30 '24 10:08 diederikdehaas

Actually there's already a branch at https://github.com/phkaeser/wlmaker/tree/nvidia that is updated to run with wlroots-0.18. It will need to get that cleaned up a little, and compile conditionally to support both 0.17 and 0.18 for smooth transition.

(meaning to imply: That may be not that much work, and should be feasible in the next weeks)

phkaeser avatar Aug 30 '24 23:08 phkaeser

Ok, great! I did look in issues and PRs, but not in other branches.

diederikdehaas avatar Sep 01 '24 17:09 diederikdehaas

With #114, the code is supposed to be ready for 0.18, and github actions in place to keep it building for both 0.17 and 0.18. For Debian Trixie, it's also verified to work with pre-packaged libwlroots-dev and has many fewer depdencies. That should also apply to BSD.

@alexmyczko -> is there something I can help with adjusting the Debian package? And, anything further needed to let it build against wlroots-0.18 ?

@jbeich -> similar for *BSD, it should build with system wlroots. Anything I can help updating?

phkaeser avatar Sep 12 '24 19:09 phkaeser

@phkaeser I guess all is fine, release a new version. You can see here:

https://sources.debian.org/src/wlmaker/0.3-2/debian/

in the changelog what is done in the latest package, and in patches/ you will find things that get patched for the package.

Debian 13 (trixie) will not be released before next year, and the freeze is also likely not to start before end of this year. https://release.debian.org/trixie/freeze_policy.html

Freezes usually take ~6 months, +-3 months.

alexmyczko avatar Sep 13 '24 05:09 alexmyczko

Builds fine on FreeBSD with both wlroots 0.17 and 0.18. Runtime is OK except #117 which is easy to work around downstream.

jbeich avatar Sep 13 '24 06:09 jbeich

wlmaker 0.4.1 looks good and was just uploaded to debian, see https://buildd.debian.org/status/package.php?p=wlmaker&suite=sid soon

alexmyczko avatar Nov 11 '24 09:11 alexmyczko

Glad we finally got it to work for Sid! -- and saw it uses 0.18 there :)

@alexmyzcko -- will 0.4.1 also make it into Trixie?

phkaeser avatar Nov 12 '24 06:11 phkaeser

in 4 days: https://qa.debian.org/excuses.php?package=wlmaker

alexmyczko avatar Nov 12 '24 10:11 alexmyczko

@alexmyczko now shows as "blocked". Is that due to the wlroots dependency that has it's upgrade challenge?

(wlmaker should build against 0.17 and 0.18. Does debian have an explicit wlroots 0.18 package it should be configured against?)

phkaeser avatar Nov 16 '24 07:11 phkaeser

It's build against libwlroots-0.18-dev which resulted in a runtime dependency against libwlroots-0.18, so for wlmaker everything is as it should be (thanks!).
The (migration) problem is 2 fold:

diederikdehaas avatar Nov 16 '24 08:11 diederikdehaas

Thanks for explaining, @diederikdehaas !

phkaeser avatar Nov 16 '24 10:11 phkaeser

Thanks for adapting it to wlroots 0.18 :+1:

And with that conclusion, I can conclude that this issue is fixed. Thanks :)

diederikdehaas avatar Nov 16 '24 17:11 diederikdehaas

Yay! 0.4.1 finally made it into Debian 13!

https://tracker.debian.org/news/1599527/wlmaker-041-2-migrated-to-testing/

phkaeser avatar Dec 30 '24 08:12 phkaeser