PhistucK

Results 43 comments of PhistucK

I guess I forgot to mention I added the requested comment?

1. I guess so, I am not nearly knowledgeable enough in the Chromium build process to answer. @dpranke (hopefully this is the right dpranke) - can you assist? (Perhaps we...

Perhaps building "all" instead of only Chromium would be the right thing to do here, as it would also compile JavaScript with Closure Compiler and other (debatable) goodies. Regarding the...

If it is scalable, I prefer `all` (I, for one, will probably work more on the Developer Tools, for example) and layout tests. I managed to run almost all of...

There is an "Id" field in IPlatformStatus - https://github.com/mayuki/PlatformStatusTracker/blob/a0c3023b4533ce14e39080b3b370a957a4b3c1ca/PlatformStatusTracker/PlatformStatusTracker.Core/Data/PlatformStatus.cs#L52 You can add it to ChangeSet - https://github.com/mayuki/PlatformStatusTracker/blob/a0c3023b4533ce14e39080b3b370a957a4b3c1ca/PlatformStatusTracker/PlatformStatusTracker.Core/Model/ChangeSet.cs#L32 And to ChangeSetViewModel - https://github.com/mayuki/PlatformStatusTracker/blob/a0c3023b4533ce14e39080b3b370a957a4b3c1ca/PlatformStatusTracker/PlatformStatusTracker.Web/ViewModels/Home/ChangeSetsViewModel.cs#L9 And - https://github.com/mayuki/PlatformStatusTracker/blob/a0c3023b4533ce14e39080b3b370a957a4b3c1ca/PlatformStatusTracker/PlatformStatusTracker.Web/ViewModels/Home/ChangesViewModel.cs#L41 And show it - https://github.com/mayuki/PlatformStatusTracker/blob/master/PlatformStatusTracker/PlatformStatusTracker.Web/Views/Home/Partial/ChangeSets.cshtml

I think the problem is that Chrome changed its model (and maybe also Mozilla)... The data is exposed as JSON, but the properties have changed a bit.

This probably needs an update - https://github.com/mayuki/PlatformStatusTracker/blob/master/PlatformStatusTracker/PlatformStatusTracker.Core/Data/PlatformStatus.cs

Also using Chrome 77 and 78 on Windows 10 (using BrowserStack).

So... Is 3 going to ship...?