phiresky comments

Results 402 comments of


                                            phiresky

improve admin and mod check to not do seq scans and return unnecessary data

Yeah I know. The other one already on lemmy.world. That's why I made it use `IF NOT EXISTS`. I don't think the difference is that important for dev setups? I...

improve admin and mod check to not do seq scans and return unnecessary data

ok i guess. i've readded the other migration. hopefully this will cover all cases.

improve admin and mod check to not do seq scans and return unnecessary data

i swear i checked the damn formatting. fixed

improve admin and mod check to not do seq scans and return unnecessary data

i've pushed the reformat of api tests with prettier 3.0 to the same branch. all other prs will also fail because of this i guess

improve admin and mod check to not do seq scans and return unnecessary data

oh god i think it's non-deterministic, sometimes using prettier 2 and sometimes prettier 3? fixed by specifying specific prettier version

Check for dead federated instances (fixes #2221)

> People won't understand why they've blocked an instance yet posts are still coming through, for example. Should be fairly easy to also update the cache where the query updates...

Check for dead federated instances (fixes #2221)

I want to mention that the fetch_local_site_data is the third most expensive function in the code base and the first-most expensive actually needed function. I'd recommend either this be merged...

fix race condition on community fetch (and improve performance)

Here's a benchmark of this change. As you can see, it noticeably improves performance, making incoming federation finish faster. It saves around 130 INSERTs and db-roundtrips per new seen community....

fix race condition on community fetch (and improve performance)

I want to mention that that list is not extremely representative of a real instance because it doesn't show any user actions, just incoming federation activity. A more accurate list...

Error enum fixed

this is great. maybe you could `impl From for LemmyError` though? so that all those `LemmyError::from_type(LemmyErrorType::CantBlockAdmin)` are shorter. then you should even be able to just use the ? operator...