phing icon indicating copy to clipboard operation
phing copied to clipboard

TstampTask with ICU syntax

Open jawira opened this issue 2 years ago • 1 comments

Hi, I modified TstampTask to handle ICU syntax, rationale is explained in https://github.com/phingofficial/phing/issues/1682

  • pattern attribute must be specified using ICU syntax
  • TstampCustomFormat only stores attributes, the logic has been moved to TstampTask
  • A warning is displayed if pattern contains % character (always used in old syntax)
  • I updated phing-grammar.rng with timezone attribute, can you please double check this since I'm not RelaxNG expert
  • Updated tests: TstampTest.xml and TouchTaskTest.xml
  • In tests locale is always en_US and timezone is always UTC

As always I'm open to any comment or change request :)

jawira avatar Aug 09 '22 21:08 jawira

Codecov Report

Merging #1683 (7a5fb2c) into main (3089d02) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              main   #1683   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
+ Complexity    7010    7009    -1     
=======================================
  Files          356     356           
  Lines        17108   17098   -10     
=======================================
+ Misses       17108   17098   -10     
Impacted Files Coverage Δ
src/Phing/Task/System/TstampCustomFormat.php 0.00% <0.00%> (ø)
src/Phing/Task/System/TstampTask.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 09 '22 21:08 codecov[bot]

Hey @jawira can you update the PR, then I'll review it!

mrook avatar Jan 15 '23 15:01 mrook

@mrook I had to update CI in order to install dependencies, can you double check changes I made in .github/workflows/build.yml plase ?

jawira avatar Jan 15 '23 17:01 jawira

LGTM @jawira, thank you!

mrook avatar Jan 19 '23 14:01 mrook