phing
phing copied to clipboard
TstampTask with ICU syntax
Hi, I modified TstampTask
to handle ICU syntax, rationale is explained in https://github.com/phingofficial/phing/issues/1682
-
pattern
attribute must be specified using ICU syntax -
TstampCustomFormat
only stores attributes, the logic has been moved toTstampTask
- A warning is displayed if
pattern
contains%
character (always used in old syntax) - I updated
phing-grammar.rng
withtimezone
attribute, can you please double check this since I'm not RelaxNG expert - Updated tests:
TstampTest.xml
andTouchTaskTest.xml
- In tests locale is always
en_US
and timezone is alwaysUTC
As always I'm open to any comment or change request :)
Codecov Report
Merging #1683 (7a5fb2c) into main (3089d02) will not change coverage. The diff coverage is
0.00%
.
@@ Coverage Diff @@
## main #1683 +/- ##
=======================================
Coverage 0.00% 0.00%
+ Complexity 7010 7009 -1
=======================================
Files 356 356
Lines 17108 17098 -10
=======================================
+ Misses 17108 17098 -10
Impacted Files | Coverage Δ | |
---|---|---|
src/Phing/Task/System/TstampCustomFormat.php | 0.00% <0.00%> (ø) |
|
src/Phing/Task/System/TstampTask.php | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hey @jawira can you update the PR, then I'll review it!
@mrook I had to update CI in order to install dependencies, can you double check changes I made in .github/workflows/build.yml
plase ?
LGTM @jawira, thank you!