Philwinkle_Fixerio icon indicating copy to clipboard operation
Philwinkle_Fixerio copied to clipboard

Makes the module compatible with Magento 1.9.4.3+

Open azambon opened this issue 4 years ago • 0 comments

See #33

This PR updates the module to take into account Magento's own implementation of the FixerIO integration.

The main model in this module was changed to be a rewrite of Magento's implementation (when this is present), and the extension configuration was changed to mirror Magento's. Basically, this module replaces Magento's implementation for versions 1.9.4.3 and above and provides an implementation that was not present for Magento versione below that one.

The only drawback that I can see is that the system config field for the api key was renamed from access_key to api_key. So if someone upgrades this module from an older version to one including this PR, he/she would have to re-enter the API key value in the configuration field, otherwise the module would not work.

azambon avatar Jun 10 '21 15:06 azambon