philwinkle
Magento 1.9.4.3
Magento 1.9.4.3 comes with fixer.io in the core. The config paths of this extension and the core are mostly the same, which leads to conflicts. Not sure how this should be handled, but maybe a big note in the README would be a good start.
Feel free to PR a note to the README
On Fri, Oct 18, 2019 at 4:21 AM Simon Sprankel [email protected] wrote:
Magento 1.9.4.3 comes with fixer.io in the core. The config paths of this extension and the core are mostly the same, which leads to conflicts. Not sure how this should be handled, but maybe a big note in the README would be a good start.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/philwinkle/Philwinkle_Fixerio/issues/33?email_source=notifications&email_token=AAEP53R7NNNJQL2DZWFKTLTQPFWW5A5CNFSM4JCED35KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSVUCNA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEP53SAYPNBWJRY6MDPXX3QPFWW5ANCNFSM4JCED35A .
--
Follow me on Twitter - @philwinkle Listen to MageTalk, the Magento Community Podcast! http://magetalk.com
Okay so there IS a conflict between Magento 1.9.4.3 and this extension, because they use the same config paths. However, the extension does still have its use cases. When using multiple base currencies, the core fixer.io integration fails with a free account. This extension does smarter API calls, so that multiple base currencies also work in the free version. I think you should decide how you want to handle that. I see two main options:
- Just add a note to the README that this is only compatible with Magento < 1.9.4.3.
- Change the config paths and release a new major version, because this is a breaking change.
Thanks Simon for handling this!
Let's go with route #2. I like maintaining the compatibility!
On Sat, Oct 19, 2019 at 1:31 PM Simon Sprankel [email protected] wrote:
Okay so there IS a conflict between Magento 1.9.4.3 and this extension, because they use the same config paths. However, the extension does still have its use cases. When using multiple base currencies, the core fixer.io integration fails with a free account. This extension does smarter API calls, so that multiple base currencies also work in the free version. I think you should decide how you want to handle that. I see two main options:
- Just add a note to the README that this is only compatible with Magento < 1.9.4.3.
- Change the config paths and release a new major version, because this is a breaking change.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/philwinkle/Philwinkle_Fixerio/issues/33?email_source=notifications&email_token=AAEP53SMDG6CDC7HEB6V2DLQPLV2XA5CNFSM4JCED35KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXM35Q#issuecomment-544132598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEP53TKUPWZRHXSC4LYXA3QPLV2XANCNFSM4JCED35A .
--
Follow me on Twitter - @philwinkle Listen to MageTalk, the Magento Community Podcast! http://magetalk.com